Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: point jupyter gallery link to jupyter wiki #17467

Merged
merged 2 commits into from
May 31, 2022
Merged

docs: point jupyter gallery link to jupyter wiki #17467

merged 2 commits into from
May 31, 2022

Conversation

curtislarson
Copy link
Contributor

The Gallery of Jupyter Notebooks currently points to a wiki with a lonely link that redirects to the jupyter wiki page. This changes the link to go directly to the wiki page.

Why:

I'm tired of clicking one extra time

What's being changed:

Fixing link

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).

@curtislarson
docs: point jupyter gallery link to jupyter wiki
c08ee71 
The [Gallery of Jupyter Notebooks](https://github.com/jupyter/jupyter/wiki/A-gallery-of-interesting-Jupyter-Notebooks) currently points to a wiki with a lonely link that redirects to the jupyter wiki page. This changes the link to go directly to the wiki page.
@welcome
Copy link

welcome bot commented Apr 29, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/working-with-files/using-files/working-with-non-code-files.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
 fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Apr 29, 2022
@ramyaparimi
Copy link
Contributor

@curtislarson
Thanks so much for opening a PR! I'll get this triaged for review ⚡

sophietheking
sophietheking approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening a PR with this fix @curtislarson ! The changes look great ⚡ I'm going to run the tests and I'll get this merged once they're passing. 🚀

@sophietheking sophietheking added the ready to merge This pull request is ready to merge label May 31, 2022
@sophietheking sophietheking merged commit 22bff6b into github:main May 31, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophietheking sophietheking

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtislarson @ramyaparimi @sophietheking