Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start waiting for processing by default. #843

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Start waiting for processing by default. #843

merged 3 commits into from
Dec 13, 2021

Conversation

chrisgavin
Copy link
Contributor

The option to wait for processing to complete has worked well during internal testing so I think we could now be at the point where we enable it by default.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary. (I don't think it's necessary, since most people will probably want to use this feature and it should only be turned off if it's causing issues.)
  • Confirm the changelog has been updated if necessary.

@chrisgavin chrisgavin requested a review from cannist December 9, 2021 10:24
@chrisgavin chrisgavin requested a review from a team as a code owner December 9, 2021 10:24
cannist
cannist reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@cannist cannist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, Chris, I had wanted to do this yesterday but did not get to it. 🙂

Just one suggestion to have more context in the change note.

CHANGELOG.md Outdated Show resolved Hide resolved
@chrisgavin @cannist
Add more context to a change note.
7bcc656 
Co-authored-by: Thomas Horstmeyer <73262256+cannist@users.noreply.github.com>
@chrisgavin chrisgavin enabled auto-merge December 13, 2021 12:04
@chrisgavin chrisgavin merged commit eacec36 into main Dec 13, 2021
@chrisgavin chrisgavin deleted the wait-for-processing-by-default branch December 13, 2021 12:19
@cannist cannist mentioned this pull request Dec 14, 2021
Merged
3 tasks
@github-actions github-actions bot mentioned this pull request Jan 11, 2022
Merged
5 tasks
@snyk-bot snyk-bot mentioned this pull request Jun 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannist cannist cannist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgavin @cannist