JS: Support import attributes #14484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
approved these changes
Oct 12, 2023
|
The evaluations could be on a bigger set of sources. |
|
The evaluations look good. The only interesting results were syntax that changed locations reported on tests in babel/babel on files like https://github.com/babel/babel/blob/main/packages/babel-parser/test/fixtures/experimental/module-attributes/valid-syntax-with-attributes/input.js import foo from "foo.json" with type: "json";The tests use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for import attributes, an evolution of import assertions. For example:
When implementing #12382, we thought the syntax of import assertions was unlikely to change. However, it did. The only difference is that instead of
assertthey now usewith. The old syntax is still allowed but deprecated.In the QL library:
getImportAssertion()predicates are deprecated, their new name isgetImportAttributes()DynamicImportExpr::getImportAttributes()is deprecated and renamed togetImportOptions()Evaluation was uneventful.
Commit-by-commit review recommended.