fix: Translation update issues #7877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Resolves gitextensions#7873 * TranslationApp fails because it tries to write the file to the non-existing directory artifacts\bin\TranslationApp\Debug\net461\Translation due to an incorrect working directory * Everytime trnaslations are updated the current application version is written in xlf files. This creates additional maintenance, yet this functionality is not utilised. The version is set to empty string. * Remove now defunct UpdateLocalEnglishTranslations.ps1 script
mstv
reviewed
Mar 18, 2020
|
I have pushed few variant of an update to the README, I'm happy with the last one. Let me know what you think. |
mstv
reviewed
Mar 20, 2020
There was a problem hiding this comment.
👍 Looks good.
In addition, I'd like to have a short comment in the CONTRIBUTING.md at line 61, e.g.
- .xlf files do not need to be modified. The English xlf is generated ...
+ Run `build.cmd -loc` to update English translations if you have changed those. The other .xlf files do not need to be modified. The English.xlf is generated ...
Co-Authored-By: Michael Seibt <36601201+mstv@users.noreply.github.com>
Co-Authored-By: Michael Seibt <36601201+mstv@users.noreply.github.com>
Co-Authored-By: Michael Seibt <36601201+mstv@users.noreply.github.com>
I have updated CONTRIBUTING.md and https://github.com/gitextensions/gitextensions/wiki/Translations |
gerhardol
approved these changes
Mar 21, 2020
|
... can be built...
|
Co-Authored-By: Michael Seibt <36601201+mstv@users.noreply.github.com>
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7873
Proposed changes
TranslationApp fails because it tries to write the file to the non-existing directory artifacts\bin\TranslationApp\Debug\net461\Translation due to an incorrect working directory
Everytime trnaslations are updated the current application version is written in xlf files. This creates additional maintenance, yet this functionality is not utilised.
The version is set to empty string.
Remove now defunct UpdateLocalEnglishTranslations.ps1 script
✒️ I contribute this code under The Developer Certificate of Origin.