Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasklog: teach *Logger how to enqueue new *SimpleTask's #2767

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

ttaylorr
Copy link
Contributor

@ttaylorr ttaylorr commented Dec 4, 2017

This pull request adds a Simple() method to the *tasklog.Logger API, which is consistent with other existing methods, and was pointed out by @technoweenie in #2757 (comment).

/cc @git-lfs/core

@ttaylorr ttaylorr added the review label Dec 4, 2017
@ttaylorr ttaylorr added this to the v2.4.0 milestone Dec 4, 2017
@ttaylorr ttaylorr requested a review from technoweenie December 4, 2017 20:10
Copy link
Contributor

@technoweenie technoweenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@ttaylorr ttaylorr merged commit 6bffda5 into master Dec 5, 2017
@ttaylorr ttaylorr deleted the simple-task-constructor branch December 5, 2017 23:29
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request May 26, 2023
The SimpleTask structure of the "tasklog" package, which was introduced
in commit 7a760b6 of PR git-lfs#2756, is used
at several points in the implementation of the "git lfs fetch" and
"git lfs prune" commands, and in each case is constructed with a
call to the NewSimpleTask() function, and then passed to a Logger
structure's Enqueue() method.

However, in commit 0cad488 of PR git-lfs#2767,
a Logger.Simple() method was added to both create a new SimpleTask
structure and pass it to a Logger structure's Enqueue() method.  This
Logger.Simple() method was added to be consistent with other existing
similar methods such as Logger.List() and Logger.Percentage().

These other methods are used consistently throughout our code
to create and enqueue tasks, so we now update the locations where
we call NewSimpleTask() to use the Logger.Simple() method instead.

This also provides an opportunity to tidy some of the surrounding
code and whitespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants