Only listen to resize events from the iframe #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/laymonage/giscus/AUV4aDUdsqULcSSnQKfTYmFiuQju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, iFrameResizer listens to resize events from the parent page. Unfortunately, using giscus' client script in an SPA will leave the event listener intact, even if the
<iframe>element is no longer there (e.g. the user moves to a different page). We cannot use iFrameResizer's react, vue, or other client libraries because we cannot know the specifics of the host website.This PR changes the iFrameResizer config to only listen to resize events from the child element, meaning that it will only resize if the giscus widget is resized. When the
<iframe>no longer exists in the page, (I think) the event won't be fired again.See davidjbradshaw/iframe-resizer#566.