Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type="button" to non-submit buttons in CommentBox #212

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Conversation

laymonage
Copy link
Member

@laymonage laymonage commented Nov 6, 2021

Regression in #211. Changing the <div> into <form> makes all the buttons fire a submit event by default.

@vercel
Copy link

vercel bot commented Nov 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/giscus/giscus/6jmc1fcBmtqkyUtmKP8ChjoHD5Uh
✅ Preview: https://giscus-git-fix-button-giscus.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant