Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romanian translation for giscus #196

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Conversation

samarulmeu
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 13, 2021

@samarulmeu is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

@samarulmeu samarulmeu mentioned this pull request Oct 13, 2021
Copy link
Member

@laymonage laymonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR!

Could you also add the few category for the plurals? Looks like it's needed for Romanian: https://unicode-org.github.io/cldr-staging/charts/37/supplemental/language_plural_rules.html#ro

Without it, some strings don't show up correctly:

image

@samarulmeu
Copy link
Contributor Author

Hope this is OK now.

@vercel
Copy link

vercel bot commented Oct 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/giscus/giscus/C3fpGYzKi1aH66FdJm9aHbtvuEsR
✅ Preview: https://giscus-git-fork-samarulmeu-patch-1-giscus.vercel.app

@laymonage
Copy link
Member

laymonage commented Oct 17, 2021

Thanks @samarulmeu! The multi-language support isn't documented yet, but you should already be able to try this by adding data-lang="ro" to your <script> tag. I'm still working on adding the configuration step and updating the docs.

If there are updates to giscus that require new translations, I hope you don't mind if I ping you for review! 😄

@samarulmeu
Copy link
Contributor Author

Thank you so much, @laymonage! And do please ping me. I really have faith in this project and really want to use it on my blogs.

As a side note, is there a way to export the comments or backup them?

@laymonage
Copy link
Member

laymonage commented Oct 17, 2021

@samarulmeu you can write a script that fetches the data from GitHub's API. It would not be within the scope of this project, though. I could try writing it just for fun when I have the time, but I'd create a new repository for that. It does sound interesting and useful.

@samarulmeu
Copy link
Contributor Author

@laymonage I will try it. I think that backup is very important as, in the end, Discussions is owned by GitHub and accidents can happen (no access to the repository, suspended access, etc). Although I do not know if you can later import them in a new repository.

@laymonage
Copy link
Member

@samarulmeu yeah, I agree on that.

Importing is possible, with a few caveats because the imported discussions and comments will be made as new ones. Some caveats I can think of right now:

  1. Timestamps on the comment itself will be replaced by the timestamp of your import.
  2. The comment author would be replaced by your username or your bot's username. There's no way to create a new comment on behalf of the actual author unless they explicitly give you the permission.
  3. Links to other discussions/issues/PRs within the same repository may be broken?

Original information for (1) and (2) can still be shown by including it in the comment body, e.g.

On Oct 17, 2021, @samarulmeu wrote:
Actual comment body here

@samarulmeu
Copy link
Contributor Author

@laymonage I did not take into account this. I agree that this are some caveats, but still I think is better to have a backup instead of nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants