Use primer/primitives v5 as theme base and update looks to match GitHub updates #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/giscus/giscus/HWFBVXJQcXxqbooGnVhi4bQqDwwv |
laymonage
force-pushed
the
use-primer-primitives
branch
from
8d3bab0 to
cfcb43c
Compare
laymonage
force-pushed
the
use-primer-primitives
branch
from
cfcb43c to
a0456aa
Compare
laymonage
changed the title
laymonage
changed the title
laymonage
force-pushed
the
use-primer-primitives
branch
from
6d7a672 to
84b028c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub released v5 of their
@primer/primitivespackage which includes a big refactoring in their color variables1. If we want to update and add GitHub themes later, it's best we move to the new color system as soon as possible.Unfortunately, this is a breaking change for users who use their own custom themes. I suppose I can makeI made the variables fall back to the old names and will remove them some time later. I don't know if they'll see this notice, though.There are also some minor updates like the copy button icon change and the added margin between direct reaction buttons.
Footnotes
https://github.com/primer/primitives/releases/tag/v5.0.0 ↩