Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on categories with GitHub custom emojis #122

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Fix crash on categories with GitHub custom emojis #122

merged 1 commit into from
Jul 3, 2021

Conversation

laymonage
Copy link
Member

GitHub has custom emojis:
:atom: :basecamp: :basecampy: :bowtie: :electron: :feelsgood: :finnadie: :goberserk: :godmode: :hurtrealbad: :neckbeard: :octocat: :rage1: :rage2: :rage3: :rage4: :shipit: :suspect: :trollface:

which is rendered using <img> tag instead of <g-emoji>, so the regex won't match. We can't use <img> tags in <option>, so let's just render an empty string.

@vercel
Copy link

vercel bot commented Jul 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/laymonage/giscus/gwPqyG6VkFQWvuAxdPtdgWJAdepb
✅ Preview: https://giscus-git-fix-crash-emoji-laymonage.vercel.app

@laymonage laymonage merged commit bca513c into main Jul 3, 2021
@laymonage laymonage deleted the fix-crash-emoji branch July 3, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@laymonage