-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Transparent Dark theme #110
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @laymonage on Vercel. @laymonage first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/laymonage/giscus/Cv93z9YFJpFo4T9zhZqozYAyXt1F |
Currently testing this on my website, hopefully it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You also need to change the [data-theme='dark']
selector for this to work.
Also, could you please change the theme name from transparent
to transparent_dark
(Transparent Dark)? We might add a "Transparent Light" theme in the future.
Co-authored-by: sage <laymonage@gmail.com>
Sure, I can change this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I probably should've made this clearer on the initial review 😅
Co-authored-by: sage <laymonage@gmail.com>
@wgyt That's good to know, thanks! One last thing, would you rather have the primary buttons (i.e. "Sign in with GitHub", "Comment", "Reply") have a background color, or just keep it transparent as it is now? |
I think that keeping them transparent is a good idea because this theme is supposed to be transparent |
Thanks! 🎉 |
Might want to check the contrast with something like https://wave.webaim.org/ |
Yeah, that's something I'll need to check on the website I used to test |
@nschonni Yeah, but it really depends on the website that uses the theme. For example, a website with a light background will have a really bad contrast with this theme, and vice versa. Even giscus' main website looks a bit weird with this theme as it uses |
not sure if it works, adds a transparent theme
Part of #37.