Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2997

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Update README.md #2997

merged 1 commit into from
Dec 22, 2021

Conversation

chipmunktail
Copy link
Contributor

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@codecov
Copy link

codecov bot commented Dec 22, 2021 •
edited
Loading

Codecov Report

Merging #2997 (59466d9) into master (8a0f95c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2997   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          41       41           
  Lines        3084     3084           
=======================================
  Hits         3041     3041           
  Misses         30       30           
  Partials       13       13
Flag Coverage Δ
go-1.13 ∅ <ø> (∅)
go-1.14 ∅ <ø> (∅)
go-1.15 ∅ <ø> (∅)
go-1.16 98.60% <ø> (ø)
go-1.17 98.50% <ø> (ø)
macos-latest 98.60% <ø> (ø)
nomsgpack 98.58% <ø> (ø)
ubuntu-latest 98.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0f95c...59466d9. Read the comment docs.

thinkerou
thinkerou approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkerou thinkerou added this to the v1.8 milestone Dec 22, 2021
@thinkerou thinkerou merged commit 1538ece into gin-gonic:master Dec 22, 2021
daheige pushed a commit to daheige/gin that referenced this pull request Apr 18, 2022
@chipmunktail @daheige
Update README.md (gin-gonic#2997)
d3cceee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

Assignees
No one assigned
Labels
document
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@chipmunktail @thinkerou