Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default validator's docs link #2738

Merged
merged 1 commit into from
May 26, 2021
Merged

Update default validator's docs link #2738

merged 1 commit into from
May 26, 2021

Conversation

iamhesir
Copy link
Contributor

The default validator has upgraded from v8 to v10, but its docs link didn't.

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@iamhesir
Update default validator's docs link
ada7b0a 
The default validator has upgraded from v8 to v10, but its docs link didn't.
@codecov
Copy link

codecov bot commented May 26, 2021 •
edited
Loading

Codecov Report

Merging #2738 (ada7b0a) into master (b5ca989) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2738   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          41       41           
  Lines        2070     2070           
=======================================
  Hits         2043     2043           
  Misses         15       15           
  Partials       12       12
Impacted Files Coverage Δ
binding/default_validator.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ca989...ada7b0a. Read the comment docs.

thinkerou
thinkerou approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@thinkerou thinkerou added this to the v1.8 milestone May 26, 2021
@thinkerou thinkerou merged commit 0cbb30a into gin-gonic:master May 26, 2021
@iamhesir iamhesir deleted the patch-1 branch May 31, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou

Assignees
No one assigned
Labels
document
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@iamhesir @thinkerou