Adding ppc64le architecture support on travis-ci #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2538 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 41 41
Lines 1989 1989
=======================================
Hits 1959 1959
Misses 17 17
Partials 13 13 Continue to review full report at Codecov.
|
|
Any views on the requested PR? |
appleboy
approved these changes
Nov 28, 2020
|
We will move from Travis to GitHub Actions next version. See #2582 |
|
@kishorkunal-raj have some unit test failed details: |
appleboy
pushed a commit
that referenced
this pull request
Jan 10, 2021
RK-GCP
added a commit
to RK-GCP/gin
that referenced
this pull request
Mar 18, 2021
* Revert "Adding ppc64le architecture support on travis-ci (gin-gonic#2538)" (gin-gonic#2602) * test: fixed the TestUnixSocket test on windows (gin-gonic#2595) Co-authored-by: thinkerou <thinkerou@gmail.com> * gin mode unknown: show available mode (gin-gonic#2567) Co-authored-by: thinkerou <thinkerou@gmail.com> * fix error gin support min Go version (gin-gonic#2584) Co-authored-by: thinkerou <thinkerou@gmail.com> * Fixes to the graceful shutdown example (gin-gonic#2552) * Change error comparison to use errors.Is() and add a line of whitespace before the if statement on graceful shutdown * Change from log.Fatalf to log.Printf to ensure the graceful shutdown actually works Co-authored-by: J. J. Bigorra <josep@prowarehouse.nl> Co-authored-by: thinkerou <thinkerou@gmail.com> * basic auth: fix timing oracle (gin-gonic#2609) Co-authored-by: thinkerou <thinkerou@gmail.com> * chore: Deleted spaces (gin-gonic#2622) * Remove the tedious named return value (gin-gonic#2620) Co-authored-by: thinkerou <thinkerou@gmail.com> Co-authored-by: thinkerou <thinkerou@gmail.com> Co-authored-by: Jeff <laojianzi1994@gmail.com> Co-authored-by: Rubi <14269809+codenoid@users.noreply.github.com> Co-authored-by: Qt <golang.chen@gmail.com> Co-authored-by: Josep Jesus Bigorra Algaba <42377845+averageflow@users.noreply.github.com> Co-authored-by: J. J. Bigorra <josep@prowarehouse.nl> Co-authored-by: Snawoot <vladislav-ex-github@vm-0.com> Co-authored-by: Alexander Melentyev <55826637+alexander-melentyev@users.noreply.github.com> Co-authored-by: Andy Pan <panjf2000@gmail.com>
thinkerou
added a commit
that referenced
this pull request
Apr 11, 2021
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 22, 2021
* Revert "Adding ppc64le architecture support on travis-ci (gin-gonic#2538)" This reverts commit fca3f95. * not support go1.12 * fix * Update errors_test.go * Update debug.go (cherry picked from commit ee4de84)
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 22, 2021
* Revert "Adding ppc64le architecture support on travis-ci (gin-gonic#2538)" This reverts commit fca3f95. * not support go1.12 * fix * Update errors_test.go * Update debug.go (cherry picked from commit ee4de84)
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 22, 2021
* Revert "Adding ppc64le architecture support on travis-ci (gin-gonic#2538)" This reverts commit fca3f95. * not support go1.12 * fix * Update errors_test.go * Update debug.go (cherry picked from commit ee4de84)
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 22, 2021
* Revert "Adding ppc64le architecture support on travis-ci (gin-gonic#2538)" This reverts commit fca3f95. * not support go1.12 * fix * Update errors_test.go * Update debug.go (cherry picked from commit ee4de84)
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 23, 2021
* Revert "Adding ppc64le architecture support on travis-ci (gin-gonic#2538)" This reverts commit fca3f95. * not support go1.12 * fix * Update errors_test.go * Update debug.go (cherry picked from commit ee4de84)
thinkerou
added a commit
that referenced
this pull request
Nov 24, 2021
thinkerou
added a commit
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had added ppc64le(Linux on Power) architecture support on travis-ci in the PR and looks like its been successfully added. I believe it is ready for the final review and merge. The travis ci build logs can be verified from the link below.
https://travis-ci.com/github/kishorkunal-raj/gin/builds/191395651
Reason behind running tests on ppc64le: This package is included in the ppc64le versions of RHEL and Ubuntu - this allows the top of tree to be tested continuously as it is for Intel, making it easier to catch any possible regressions on ppc64le before the distros begin their clones and builds. This reduces the work in integrating this package into future versions of RHEL/Ubuntu.
Please have a look.