Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some missing dots on README #2519

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Add some missing dots on README #2519

merged 2 commits into from
Oct 16, 2020

Conversation

zasdaym
Copy link
Contributor

@zasdaym zasdaym commented Oct 3, 2020

Signed-off-by: Zasda Yusuf Mikail zasdaym@gmail.com

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@zasdaym
Add some missing dots on README
41fe9d0 
Signed-off-by: Zasda Yusuf Mikail <zasdaym@gmail.com>
@codecov
Copy link

codecov bot commented Oct 3, 2020 •
edited
Loading

Codecov Report

Merging #2519 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2519   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          41       41           
  Lines        1951     1951           
=======================================
  Hits         1921     1921           
  Misses         17       17           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a6986...30102ae. Read the comment docs.

@appleboy appleboy added this to the 1.7 milestone Oct 4, 2020
@appleboy appleboy requested a review from thinkerou October 14, 2020 01:12
@appleboy
Copy link
Member

@thinkerou I don't have permission to merge this PR.

thinkerou
thinkerou approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkerou thinkerou merged commit d541085 into gin-gonic:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
document
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@zasdaym @appleboy @thinkerou