Drop 7.8 compatibility and -Wall clean #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this patch - has not been validated with a test-run yet - has not been validated to compile on Windows - hides some of the possibly important unused/shadowning warnings.
Somebody with more understanding of the compiler should look at each of these warnings and decide how to fix the issue that they point at.
meiersi
changed the title
|
Can this be merged? |
|
is this PR out of date or does it still make sense? |
|
sorry the inactivity, this broke my work tree so I held off merging it far too long. In the meantime I've gradually removed obsolete code and fixed some warnings |
|
No problem. Thx for all the great work!
Luite Stegeman <notifications@github.com> schrieb am So. 6. Mai 2018 um
13:43:
… Closed #439 <#439>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#439 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AANuPeU3bpP6g28pXIB2RFnYJbaq4z34ks5tvuHmgaJpZM4GYEbW>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps towards #438 . What remains to be done is