Open
Description
I've just compiled ghcjs:master using stack and this worked great. It also means that I can use ghcid --command='ghci' to get a really quick iteration cycle going for working on GHCJS. As a first contribution, I'd be interested in getting rid of the many warnings that stem from code that is in there only for supporting older GHC's (Control.Applicative I'm looking at you and your ilk ;-). Would a PR that reduces the warning noise be sensible? Or do you have other plans @luite?
(Note that there also seem to be a few important warnings about missing pattern matches and unused identifiers that I'd leave in for @luite to look at.)
Metadata
Metadata
Assignees
Labels
No labels
Activity
luite commentedon Oct 28, 2015
I have to admit that I haven't really been paying much attention to warnings, and the cleanliness of the code in general, due to most of the work being on the
ghcjs-baselibrary and the rts inshims, plus new codegen stuff.I wouldn't mind a patch, but any significant changes in the code generator would require a reboot anyway. Maybe changing the warning flags is a more efficient way to get there, for now?
meiersi commentedon Oct 28, 2015
I can understand you are currently focusing on different parts. However, I don't fully understand your answer.
masterbranch?masterbranch? If yes, what branch should/could I help you out with getting these menial things like -Wall cleaning done?meiersi commentedon Oct 28, 2015
A related question: is it OK if a patch also drops trailing whitespace in the files I edit? Or would you like a separate PR that drops all trailing whitespace on
master? Or should I avoid dropping any trailing whitespace?luite commentedon Oct 28, 2015
old-baseGo ahead and drop trailing whitespace
cartazio commentedon Apr 18, 2017
@meiersi @luite a) does this cleanup still make sense to merge in? b) how can i help?
meiersi-da commentedon Apr 18, 2017
I haven't been working on this anymore; and don't have time to update the PR at the moment. @luite your call :)