Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Roberta embeddings #10695

Merged
merged 1 commit into from
Dec 7, 2024
Merged

feat: add support for Roberta embeddings #10695

merged 1 commit into from
Dec 7, 2024

Conversation

Ssukriti
Copy link
Contributor

@Ssukriti Ssukriti commented Dec 6, 2024 •
edited
Loading

This PR adds support for Roberta Model architecture, enabling conversion to gguf.

I have tested the PR with a Roberta and BERT model , to confirm the changes.

(cc : @gabe-l-hart )

@github-actions github-actions bot added the python python script changes label Dec 6, 2024
ggerganov
ggerganov approved these changes Dec 7, 2024
View reviewed changes
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding an example or two of how embeddings models can be used in the main README.md. Either with the llama-embedding or llama-server example.

@ggerganov ggerganov merged commit 784a14a into ggerganov:master Dec 7, 2024
1 check passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Dec 20, 2024
@Ssukriti @arthw
convert : add support for Roberta embeddings (ggerganov#10695)
a1b52c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
python python script changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ssukriti @ggerganov