Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgpu-core] make implicit_pipeline_ids arg optional for users that don't provide IDs #5971

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jul 17, 2024

Connections
Fixes #5029.
Fixes #4073.

Description
See #5029 (comment).

Testing
Tested locally that memory usage is no longer steadily increasing with this patch, whereas it does without it.

@teoxoy teoxoy requested a review from a team as a code owner July 17, 2024 10:03
@teoxoy teoxoy merged commit 91924fb into gfx-rs:trunk Jul 17, 2024
25 checks passed
@teoxoy teoxoy deleted the opt-implicit_pipeline_ids branch July 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WGPU leaks the implicit PLL of pipeline layouts ComputePipeline is never freed
2 participants