Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Benchmarks #5694

Merged
merged 1 commit into from
May 16, 2024
Merged

Add Benchmarks #5694

merged 1 commit into from
May 16, 2024

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented May 12, 2024 •
edited
Loading

Connections

Closes #5443

Description

This is our first useful foray into benchmarking.

Adds benchmarking infrastructure and adds some more labeling within the code to make traces more useful.

image

I will write up some of my findings from this in an issue later.

Testing

Should be compile and run tested by existing infra.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner May 12, 2024 08:52
@JMS55
Copy link
Collaborator

JMS55 commented May 12, 2024 •
edited
Loading

Can I please request some benchmarks?

  1. Making a very large (>500MB, 2GB is the limit iirc) buffer, then making a second, slightly bigger one, and destroying the original. My project allocates a lot of very large buffers, but when I need to grow them I make a bigger one, copyBuffer to transfer the contents, and then destroy the old. I'm very curious how wgpu's memory allocators handle this.
  2. Bind group creation benchmarks (currently we don't cache these between frames).

@cwfitzgerald
Copy link
Member Author

  1. Should already be covered by the buffer creation benchmark
  2. Can add that, yeah

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner May 13, 2024 11:59
@cwfitzgerald cwfitzgerald force-pushed the benchmarks branch 6 times, most recently from 873aebc to 350f926 Compare May 16, 2024 04:09
nical
nical approved these changes May 16, 2024
View reviewed changes
benches/README.md Show resolved Hide resolved
@cwfitzgerald cwfitzgerald merged commit eeb1a9d into gfx-rs:trunk May 16, 2024
21 checks passed
@cwfitzgerald cwfitzgerald deleted the benchmarks branch May 16, 2024 13:05
jimblandy pushed a commit to jimblandy/wgpu that referenced this pull request May 23, 2024
@cwfitzgerald @jimblandy
Add Benchmarks (gfx-rs#5694)
99b2f1a
@Wumpf Wumpf mentioned this pull request Jun 2, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical nical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wgpu needs benchmarks
3 participants
@cwfitzgerald @JMS55 @nical