Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation comments for Rust 1.66. #3310

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

jimblandy
Copy link
Member

Somewhere after 1.64 but by 1.66, rustdoc started checking for unmatched HTML tags in doc strings, meaning that text like

/// Convenience function turning Option<Selector> into this enum.

causes problems, since rustdoc will pass through <Selector> as HTML tag, which browsers displaying the output will misunderstand.

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • (unnecessary) Add change to CHANGELOG.md. See simple instructions inside file.

Somewhere after 1.64 but by 1.66, `rustdoc` started checking for
unmatched HTML tags in doc strings, meaning that text like

    /// Convenience function turning Option<Selector> into this enum.

causes problems, since `rustdoc` will pass through `<Selector>` as
HTML tag, which browsers displaying the output will misunderstand.
@jimblandy jimblandy requested review from nical and removed request for nical December 19, 2022 19:27
@jimblandy
Copy link
Member Author

Documentation only, non-substantive, merging without review.

@jimblandy jimblandy merged commit de070b2 into gfx-rs:master Dec 19, 2022
@jimblandy jimblandy deleted the doc-code-quotes branch December 13, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant