You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
Add change to CHANGELOG.md. See simple instructions inside file.
Description
Now, dependencies used by more than one package use inheritance instead.
In the [package] table, three fields of name, description, and version remain independent. Although each crate version is now synchronized, they should be able to upgrade the version separately, in dummy, player two crates, the authors value is not the same, so it also remains independent.
- In dummy, player crates, the authors field value are not the same, so they remain independent.
- The value of homepage field is "https://wgpu.rs/" in wgpu crate and "https://github.com/gfx-rs/wgpu" in other crate, I'm not sure if this is intentional or not, but now it is inherited as "https://wgpu.rs/" value
deno_webgpu and cts_runner are not workspace members, so inheritance cannot be used.
Testing
Tested locally on macOS, Windows11 and Android 12.
Not a blocker, but I wanted to note that this PR would be a breaking change, because it would change the repo's current MSRV to Rust 1.64, AIUI:
Minimum Supported Rust Version is 1.62. It is enforced on CI (in "/.github/workflows/ci.yml") with RUST_VERSION variable. This version can only be upgraded in breaking releases.
@ErichDonGubler any changes in either wgpu or naga going into master can break - we don't really do patch releases outside of major bugs, and when we patch we go into the specific version (eg. v0.14) branch.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Description
Now, dependencies used by more than one package use inheritance instead.
In the
[package]table, three fields ofname,description, andversionremain independent. Although each crateversionis now synchronized, they should be able to upgrade the version separately, in dummy, player two crates, the authors value is not the same, so it also remains independent.- In
dummy,playercrates, theauthorsfield value are not the same, so they remain independent.- The value of
homepagefield is "https://wgpu.rs/" in wgpu crate and "https://github.com/gfx-rs/wgpu" in other crate, I'm not sure if this is intentional or not, but now it is inherited as "https://wgpu.rs/" valuedeno_webgpuandcts_runnerare not workspace members, so inheritance cannot be used.Testing
Tested locally on macOS, Windows11 and Android 12.