Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cbindgen flags #298

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fix cbindgen flags #298

merged 1 commit into from
Aug 21, 2019

Conversation

kvark
Copy link
Member

@kvark kvark commented Aug 20, 2019

No description provided.

@kvark kvark requested a review from grovesNL August 20, 2019 18:59
Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
bors r+


[parse.expand]
crates = ["wgpu-native"]
include = ["wgpu-native"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it was the _ instead of - 😅

@@ -1,4 +1,7 @@
header = "#define WGPU_LOCAL"
header = """
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we could just add "wgpu_instance_create_surface_from_winit" to exclude to remove this from the header

bors bot added a commit that referenced this pull request Aug 20, 2019
298: Fix cbindgen flags r=grovesNL a=kvark



Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 21, 2019

Build succeeded

@bors bors bot merged commit 0296e82 into gfx-rs:master Aug 21, 2019
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
298: Added a screenshot for harmony. r=kvark a=StarArawn



Co-authored-by: John Mitchell <john.mitchell@mangolanguages.com>
@kvark kvark deleted the bindgen branch August 24, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants