Add a vulkan workaround for large buffers. #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added an entry in the wiki. |
cwfitzgerald
requested changes
Jun 21, 2022
Some drivers run into issues when buffer sizes and ranges are larger than what fits signed 32 bit integer. Adapt the maximum buffer size accordingly.
atadier
pushed a commit
to atadier/wgpu
that referenced
this pull request
Jun 23, 2022
* Add Limit::max_buffer_size. * Prevent very large buffer with some drivers. Some drivers run into issues when buffer sizes and ranges are larger than what fits signed 32 bit integer. Adapt the maximum buffer size accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some drivers run into fairly risky integer overflows with buffer sizes and buffer range parameters that don't fit in a 32 bits integer. Mesa/lavapipe is one of them.
This PR adds a driver workaround flag which, when set, limits buffer allocation sizes to what fits an i32.
For some context about mesa, it basically boils down to internal commands passing buffer ranges and sizes via
pipe_box, see https://github.com/mesa3d/mesa/blob/81d6ae31d6f18d6fd2894a8b6dfe4323eea797f9/src/gallium/include/pipe/p_state.h#L529I am not sure how to be more precise about enabling the workaround on linux. I suspect that it does not affect the nvidia proprietary driver, Iet me know if I can improve this.
Also I have no doubt that plenty of other drivers make the same mistake. If you want to be on the safe side, I don't think it would be unreasonable to set this workaround on all android devices (these tend to have more limited available memory anyway).
Testing
None.