get_supported_formats: sort like the old get_preferred_format and simplify return type #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Jun 20, 2022
atadier
pushed a commit
to atadier/wgpu
that referenced
this pull request
Jun 23, 2022
…plify return type (gfx-rs#2786) * get_supported_formats: sort srgb first like the old get_preferred_format * get_supported_formats: simplify return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Follow up to #2783 . Alternative to #2785 .
Description
Makes the first returned format the same as the old get_preferred_format. Simplifies the return type, and consequently the examples/
Testing
Ran some examples.