hal: switch texture copies to expect physical sizes #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
force-pushed
the
tex-size
branch
5 times, most recently
from
62a17a3 to
2dab02a
Compare
cwfitzgerald
approved these changes
Sep 7, 2021
|
Cleaned up now, and it looks a bit better. Thanks for the review! |
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Sep 8, 2021
kvark
added a commit
that referenced
this pull request
Sep 8, 2021
|
published in wgpu-hal-0.10.4 |
kvark
removed
the
PR: needs back-porting
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #1895
Description
Currently, wgpu-core expects physical sizes for texture copies, but wgpu-hal expects virtual.
Moreover, Metal texture-texture copies already expect physical (but not buffer-related copies), which wasn't handled properly.
This PR fixes Metal properly and aligns wgpu-hal copy API with wgpu-core.
Testing
Tested the examples on metal. Can confirm the "skybox" example no longer throws a validation error on Metal, at least.