Add support for WGSL's atomicCompareExchangeWeak with the `__atomic…
#2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweinstock314
force-pushed
the
atomic-compare-exchange-spirv
branch
from
2641b3b to
ee026e8
Compare
…_compare_exchange_result` struct, and add SPIR-V codegen for it. Partially addresses gpuweb/gpuweb#2113, gfx-rs#1755.
…32 atomics with it.
teoxoy
requested changes
Dec 12, 2022
There was a problem hiding this comment.
Looks good, just missing some validation here:
Line 1395 in 2dcb696
We should check that the comparison type is of the form:
struct __atomic_compare_exchange_result<T> {
old_value : T; // old value stored in the atomic
exchanged : bool; // true if the exchange was done
}
aweinstock314
force-pushed
the
atomic-compare-exchange-spirv
branch
from
8e06c82 to
462a34d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_compare_exchange_result` struct, and add SPIR-V codegen for it.
Partially addresses gpuweb/gpuweb#2113, #1755.