Test non-embedded versions of libev and c-ares #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream distributors like to use their system libraries for some reason, so make sure that works, at least with the versions we have. Previously at least one test was broken. Fixes #759
jamadden
force-pushed
the
non-embed-build
branch
from
1d533de to
08d4122
Compare
|
Travis build is green; appveyor build is irrelevant for this. Merging. |
jamadden
added a commit
that referenced
this pull request
Mar 9, 2016
Test non-embedded versions of libev and c-ares
hashbrowncipher
pushed a commit
to hashbrowncipher/gevent
that referenced
this pull request
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream distributors like to use their system libraries for some reason, so make sure that works, at least with the versions we have. Previously at least one test was broken.
Travis doesn't seem to have libev and c-ares installed, so we build from our included source; this meant adding back a few files that we'd stripped previously.
Fixes #759