Little exactness tweaks #1874
Merged
Little exactness tweaks #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\\ is only for the beginning of UNC paths, e.g. \\host-name\share-name\file-path as per https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file
In the shell, spaces are significant in a path with brace expansion, and break it. (As opposed to in Rust module brace expansion.)
Keats
requested changes
May 24, 2022
| @@ -419,7 +419,7 @@ pub fn serve( | |||
| broadcaster | |||
| }; | |||
|
|
|||
| println!("Listening for changes in {}{{{}}}", root_dir.display(), watchers.join(", ")); | |||
There was a problem hiding this comment.
Why? It's not an actual regex but the space is there to make it easier to read
There was a problem hiding this comment.
It's written like a shell brace-expansion (not a regex) and I copied and pasted it to a shell command (ls, if I remember right) to look at the timestamps on those files, and it didn't work because the spaces end up being wrong extra characters in the filesystem paths.
For someone just looking at it the extra space doesn't matter, but in that case, could leave off the {} so it isn't taken literally.
Keats
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: