-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead broken code #793
Conversation
The only use of that function was removed in dc4a697, the second commit touching stores/ini/store.go. |
It does seem version dependant, since it works for me on 1.13. But yeah, let's get rid of it. |
It seems to be more a warning with go 1.15 (golang/go#32479, golang/go#3939), but that seems to make |
33322a1
to
47cf265
Compare
@ajvb it seems that Travis is still active for this repository, which causes it to show up as a CI step which never runs and blocks completion of CI (especially since it is marked as "Required"). I guess someone with admin rights needs to disable / remove it. |
@felixfontein Thanks, fixed. |
The function
encodeMetadataItem
in stores/ini/store.go is not used anywhere, and fails compilation (see #774).The failure might be Go version dependent (my
go version
saysgo version go1.15.6 linux/amd64
), but since the code isn't used, I guess it's best to just remove it.