fix(sidecar): Fix is sidecar running check timeouts #634
+30
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `timeout` field we were using is only for socket timeout, causing hanging when there's an unresponsive server running on the same port. This PR fixes that along with the retry logic and its interaction with SIGINT signalling. Fixes 627.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BYK
pushed a commit
that referenced
this pull request
Dec 14, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/astro@2.3.0 ### Minor Changes - Add support for rich breadcrumbs ([#632](#632)) ### Patch Changes - Updated dependencies \[[`09d3179ccadb61a1fbb119d3a2a8d9315921442e`](09d3179), [`319fef8422dea9425b7f230eab9b7294fbeb5a72`](319fef8), [`0c2ade8e5699e855a31a603067aa575d7580894e`](0c2ade8), [`12c9552909f8b54f4106e2a2f955475955c0413a`](12c9552)]: - @spotlightjs/spotlight@2.9.0 ## @spotlightjs/electron@1.3.0 ### Minor Changes - Add support for rich breadcrumbs ([#632](#632)) ### Patch Changes - More resillient envelope parsing to prevent crashes on bad data ([#629](#629)) - Fix encoding related corruption on binary envelope payloads ([#631](#631)) - Updated dependencies \[[`09d3179ccadb61a1fbb119d3a2a8d9315921442e`](09d3179), [`319fef8422dea9425b7f230eab9b7294fbeb5a72`](319fef8), [`9759da2d2951e77b1aabd408769b89066d91425e`](9759da2), [`0c2ade8e5699e855a31a603067aa575d7580894e`](0c2ade8), [`12c9552909f8b54f4106e2a2f955475955c0413a`](12c9552)]: - @spotlightjs/overlay@2.9.0 - @spotlightjs/sidecar@1.10.0 ## @spotlightjs/overlay@2.9.0 ### Minor Changes - Add support for rich breadcrumbs ([#632](#632)) ### Patch Changes - More resillient envelope parsing to prevent crashes on bad data ([#629](#629)) - Add missing UMD bundle ([#626](#626)) - Fix encoding related corruption on binary envelope payloads ([#631](#631)) ## @spotlightjs/sidecar@1.10.0 ### Minor Changes - Add support for rich breadcrumbs ([#632](#632)) ### Patch Changes - Fix timeout mechanism on is sidecar running check ([#634](#634)) - Fix encoding related corruption on binary envelope payloads ([#631](#631)) ## @spotlightjs/spotlight@2.9.0 ### Minor Changes - Add support for rich breadcrumbs ([#632](#632)) ### Patch Changes - More resillient envelope parsing to prevent crashes on bad data ([#629](#629)) - Fix timeout mechanism on is sidecar running check ([#634](#634)) - Fix encoding related corruption on binary envelope payloads ([#631](#631)) - Updated dependencies \[[`09d3179ccadb61a1fbb119d3a2a8d9315921442e`](09d3179), [`319fef8422dea9425b7f230eab9b7294fbeb5a72`](319fef8), [`9759da2d2951e77b1aabd408769b89066d91425e`](9759da2), [`0c2ade8e5699e855a31a603067aa575d7580894e`](0c2ade8), [`12c9552909f8b54f4106e2a2f955475955c0413a`](12c9552)]: - @spotlightjs/overlay@2.9.0 - @spotlightjs/sidecar@1.10.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage ? 31.43%
=======================================
Files ? 92
Lines ? 5433
Branches ? 100
=======================================
Hits ? 1708
Misses ? 3725
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
timeoutfield we were using is only for socket timeout, causing hanging when there's an unresponsive server running on the same port. This PR fixes that along with the retry logic and its interaction with SIGINT signalling.Fixes #627.