Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidecar): Revamp build process, export all types #616

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix(sidecar): Revamp build process, export all types #616

merged 1 commit into from
Dec 6, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 6, 2024

Fixes #610

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 11:22am

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.32%. Comparing base (6240009) to head (6d93954).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   31.32%   31.32%           
=======================================
  Files          92       92           
  Lines        5421     5421           
  Branches       99       99           
=======================================
  Hits         1698     1698           
  Misses       3723     3723

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK requested review from Lms24 and Shubhdeep12 December 6, 2024 11:25
Shubhdeep12
Shubhdeep12 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@Shubhdeep12 Shubhdeep12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BYK BYK merged commit a77a869 into main Dec 6, 2024
17 checks passed
@BYK BYK deleted the byk/fix/sidecar-build-types branch December 6, 2024 12:54
@sentry-release-bot sentry-release-bot bot mentioned this pull request Dec 11, 2024
Merged
BYK pushed a commit that referenced this pull request Dec 11, 2024
@sentry-release-bot @github-actions
meta(changelog): Update package versions (#622)
8dfb11a 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/spotlight@2.8.0

### Minor Changes

- Add Sentry SDK for monitoring
([#620](#620))

### Patch Changes

-   Fix Spotlight UI not using correct sidecar URL w/ non-default port
    ([#618](#618))

- Don't alter body styles at all
([#615](#615))

-   Make in-browser direct Sentry SDK link more graceful at the start
    ([#614](#614))

-   Updated dependencies

\[[`7ea060b832a67cf39676d7fbdbbecb02bb2830e3`](7ea060b),

[`705595349718abb1dea188efc92ab02a4268f323`](7055953),

[`76bc48618812f260b8788b83926fa36fbd9ade35`](76bc486),

[`4716ddeda0e52289b0f9bc9889ffcf957a69d1a8`](4716dde),

[`a77a8698bd892762b149b555058eb345fac2c686`](a77a869),

[`6240009c99fa4699f25325e356b32dc8849e3b92`](6240009)]:
    -   @spotlightjs/overlay@2.8.1
    -   @spotlightjs/sidecar@1.9.3

## @spotlightjs/astro@2.2.1

### Patch Changes

-   Updated dependencies

\[[`455f6966d0602af38fd0835627d11dea03b88362`](455f696),

[`4716ddeda0e52289b0f9bc9889ffcf957a69d1a8`](4716dde),

[`6240009c99fa4699f25325e356b32dc8849e3b92`](6240009),

[`f0bb9a98b4df7ce49c9fd73a093dc7b2005305b9`](f0bb9a9)]:
    -   @spotlightjs/spotlight@2.8.0

## @spotlightjs/electron@1.2.1

### Patch Changes

-   Updated dependencies

\[[`7ea060b832a67cf39676d7fbdbbecb02bb2830e3`](7ea060b),

[`705595349718abb1dea188efc92ab02a4268f323`](7055953),

[`76bc48618812f260b8788b83926fa36fbd9ade35`](76bc486),

[`4716ddeda0e52289b0f9bc9889ffcf957a69d1a8`](4716dde),

[`a77a8698bd892762b149b555058eb345fac2c686`](a77a869),

[`6240009c99fa4699f25325e356b32dc8849e3b92`](6240009)]:
    -   @spotlightjs/overlay@2.8.1
    -   @spotlightjs/sidecar@1.9.3

## @spotlightjs/overlay@2.8.1

### Patch Changes

- Use a maintained version of ReactJsonViewer
([#611](#611))

- - Added a createTab helper function
([#606](#606))

- Added Trace root transaction name in Trace detail header
([#612](#612))

- Don't alter body styles at all
([#615](#615))

-   Make in-browser direct Sentry SDK link more graceful at the start
    ([#614](#614))

## @spotlightjs/sidecar@1.9.3

### Patch Changes

- Fix sidecar package build, export all from dist with types
([#616](#616))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubhdeep12 Shubhdeep12 Shubhdeep12 approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing types for @spotlightjs/sidecar/vite-plugin v1.9.2
2 participants
@BYK @Shubhdeep12