Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate codecov uploader #1607

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Migrate codecov uploader #1607

merged 4 commits into from
Nov 8, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Nov 6, 2021

Closes #1591

@st0012 st0012 added the testing label Nov 6, 2021
@st0012 st0012 self-assigned this Nov 6, 2021
@st0012 st0012 force-pushed the migrate-codecov-uploader branch 3 times, most recently from 669e54a to 74aa729 Compare November 6, 2021 12:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021 •
edited
Loading

Codecov Report

Merging #1607 (2fe6a96) into master (81c0f81) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
+ Coverage   98.45%   98.47%   +0.02%     
==========================================
  Files         130      130              
  Lines        7230     7206      -24     
==========================================
- Hits         7118     7096      -22     
+ Misses        112      110       -2
Impacted Files Coverage Δ
sentry-sidekiq/lib/sentry-sidekiq.rb 73.91% <0.00%> (-17.40%) ⬇️
sentry-rails/app/jobs/sentry/send_event_job.rb 60.00% <0.00%> (-13.34%) ⬇️
sentry-resque/lib/sentry/resque.rb 100.00% <0.00%> (ø)
sentry-rails/lib/sentry/rails/configuration.rb 100.00% <0.00%> (+3.84%) ⬆️
sentry-rails/lib/sentry/rails/active_job.rb 97.14% <0.00%> (+5.25%) ⬆️
.../sentry/rails/tracing/active_storage_subscriber.rb 100.00% <0.00%> (+7.69%) ⬆️
.../lib/sentry/rails/rescued_exception_interceptor.rb 100.00% <0.00%> (+8.69%) ⬆️
...ntry/rails/tracing/action_controller_subscriber.rb 100.00% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c0f81...2fe6a96. Read the comment docs.

@st0012 st0012 force-pushed the migrate-codecov-uploader branch from 74aa729 to 50d6346 Compare November 6, 2021 12:43
@st0012
Add rexml to development dependencies
6a2914a 
After Ruby 3.0, rexml isn't a default gem anymore and needed to be
installed separately. But because `simplecov-cobertura` doesn't declare
it as a dependency, we need to do it manually.
@st0012 st0012 force-pushed the migrate-codecov-uploader branch from 3fb1cc0 to 6a2914a Compare November 6, 2021 13:56
@st0012
Copy link
Collaborator Author

st0012 commented Nov 6, 2021

Not directly related but I also opened a PR to help fix simplecov-cobertura: dashingrocket/simplecov-cobertura#21

@st0012 st0012 requested a review from sl0thentr0py November 7, 2021 21:58
@st0012 st0012 merged commit 8426c82 into master Nov 8, 2021
@st0012 st0012 deleted the migrate-codecov-uploader branch November 8, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

@st0012 st0012

Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate codecov's uploader
3 participants
@st0012 @codecov-commenter @sl0thentr0py