Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update readme #1091

Merged
merged 6 commits into from
Nov 28, 2024
Merged

docs: update readme #1091

merged 6 commits into from
Nov 28, 2024

Conversation

JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Nov 27, 2024 •
edited
Loading

fixes #1078

  • Update crashpad compiler version
  • Add submodule update to the What is Inside section
  • List system dependencies in README (already in Contributing, do we need to duplicate?)

#skip-changelog

JoshuaMoelans
JoshuaMoelans commented Nov 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
JoshuaMoelans
JoshuaMoelans commented Nov 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@JoshuaMoelans JoshuaMoelans marked this pull request as ready for review November 27, 2024 13:24
supervacuus
supervacuus approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor fixes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
JoshuaMoelans and others added 2 commits November 27, 2024 15:37
@JoshuaMoelans @supervacuus
apply suggestion from code review
07f48e2 
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
@JoshuaMoelans
apply suggestions from code review
25e71b3
@JoshuaMoelans JoshuaMoelans merged commit 679913e into master Nov 28, 2024
7 checks passed
@JoshuaMoelans JoshuaMoelans deleted the joshua/docs/update_readme branch November 28, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supervacuus supervacuus supervacuus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "git submodule update --init --recursive" in README
2 participants
@JoshuaMoelans @supervacuus