fix(v8/sveltekit): Ensure source maps deletion is called after source maps upload #14963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps upload (#14942) - replace the original release management plugin with a custom one where we start release creation on `closeBundle` - replace the original file deletion plugin with a custom one where we start deletion on `closeBundle` - in both cases, further ensuresthat the plugin is only invoked for build and as late as possible (`enforce: 'post'`). - searche for the release management plugin by its old and new name introduced in getsentry/sentry-javascript-bundler-plugins#647 - slightly rename the custom source maps uploading plugin for better convention; as well as some variables for better readability - add unit tests for the new custom sub plugins
Lms24
changed the title
s1gr1d
approved these changes
Jan 9, 2025
Lms24
changed the title
|
Argh I missed the commit message changing itself. Sorry to whoever is making the changelog 😬 |
This was referenced Jan 10, 2025
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Jan 15, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.48.0` -> `8.50.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/8.48.0/8.50.0) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript (@​sentry/node)</summary> ### [`v8.50.0`](https://github.com/getsentry/sentry-javascript/releases/tag/8.50.0) [Compare Source](getsentry/sentry-javascript@8.49.0...8.50.0) - feat(v8/react): Add support for React Router `createMemoryRouter` ([#​14985](getsentry/sentry-javascript#14985)) #### Bundle size 📦 | Path | Size | | ---------------------------------------------------------------- | ----------------- | | [@​sentry/browser](https://github.com/sentry/browser) | 23.29 KB | | [@​sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 21.96 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 35.85 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 73.19 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 63.58 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 77.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 89.43 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 39.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 27.89 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 32.69 KB | | [@​sentry/react](https://github.com/sentry/react) | 25.97 KB | | [@​sentry/react](https://github.com/sentry/react) (incl. Tracing) | 38.67 KB | | [@​sentry/vue](https://github.com/sentry/vue) | 27.57 KB | | [@​sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 37.71 KB | | [@​sentry/svelte](https://github.com/sentry/svelte) | 23.45 KB | | CDN Bundle | 24.49 KB | | CDN Bundle (incl. Tracing) | 37.56 KB | | CDN Bundle (incl. Tracing, Replay) | 72.84 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 78.2 KB | | CDN Bundle - uncompressed | 71.93 KB | | CDN Bundle (incl. Tracing) - uncompressed | 111.42 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 225.68 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 238.78 KB | | [@​sentry/nextjs](https://github.com/sentry/nextjs) (client) | 38.92 KB | | [@​sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 36.35 KB | | [@​sentry/node](https://github.com/sentry/node) | 162.82 KB | | [@​sentry/node](https://github.com/sentry/node) - without tracing | 98.95 KB | | [@​sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 126.65 KB | ### [`v8.49.0`](https://github.com/getsentry/sentry-javascript/releases/tag/8.49.0) [Compare Source](getsentry/sentry-javascript@8.48.0...8.49.0) - feat(v8/browser): Flush offline queue on flush and browser online event ([#​14969](getsentry/sentry-javascript#14969)) - feat(v8/react): Add a `handled` prop to ErrorBoundary ([#​14978](getsentry/sentry-javascript#14978)) - fix(profiling/v8): Don't put `require`, `__filename` and `__dirname` on global object ([#​14952](getsentry/sentry-javascript#14952)) - fix(v8/node): Enforce that ContextLines integration does not leave open file handles ([#​14997](getsentry/sentry-javascript#14997)) - fix(v8/replay): Disable mousemove sampling in rrweb for iOS browsers ([#​14944](getsentry/sentry-javascript#14944)) - fix(v8/sveltekit): Ensure source maps deletion is called after source ma… ([#​14963](getsentry/sentry-javascript#14963)) - fix(v8/vue): Re-throw error when no errorHandler exists ([#​14943](getsentry/sentry-javascript#14943)) Work in this release was contributed by [@​HHK1](https://github.com/HHK1) and [@​mstrokin](https://github.com/mstrokin). Thank you for your contribution! #### Bundle size 📦 | Path | Size | | ---------------------------------------------------------------- | ----------------- | | [@​sentry/browser](https://github.com/sentry/browser) | 23.29 KB | | [@​sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 21.96 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 35.85 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 73.19 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 63.58 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 77.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 89.44 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 39.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 27.89 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 32.69 KB | | [@​sentry/react](https://github.com/sentry/react) | 25.97 KB | | [@​sentry/react](https://github.com/sentry/react) (incl. Tracing) | 38.67 KB | | [@​sentry/vue](https://github.com/sentry/vue) | 27.57 KB | | [@​sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 37.71 KB | | [@​sentry/svelte](https://github.com/sentry/svelte) | 23.45 KB | | CDN Bundle | 24.49 KB | | CDN Bundle (incl. Tracing) | 37.56 KB | | CDN Bundle (incl. Tracing, Replay) | 72.84 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 78.2 KB | | CDN Bundle - uncompressed | 71.93 KB | | CDN Bundle (incl. Tracing) - uncompressed | 111.42 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 225.68 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 238.78 KB | | [@​sentry/nextjs](https://github.com/sentry/nextjs) (client) | 38.92 KB | | [@​sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 36.36 KB | | [@​sentry/node](https://github.com/sentry/node) | 162.82 KB | | [@​sentry/node](https://github.com/sentry/node) - without tracing | 98.95 KB | | [@​sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 126.65 KB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca-backend/pulls/476 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
alexandresoro
pushed a commit
to alexandresoro/ouca-web
that referenced
this pull request
Jan 15, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.48.0` -> `8.50.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.48.0/8.50.0) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript (@​sentry/react)</summary> ### [`v8.50.0`](https://github.com/getsentry/sentry-javascript/releases/tag/8.50.0) [Compare Source](getsentry/sentry-javascript@8.49.0...8.50.0) - feat(v8/react): Add support for React Router `createMemoryRouter` ([#​14985](getsentry/sentry-javascript#14985)) #### Bundle size 📦 | Path | Size | | ---------------------------------------------------------------- | ----------------- | | [@​sentry/browser](https://github.com/sentry/browser) | 23.29 KB | | [@​sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 21.96 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 35.85 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 73.19 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 63.58 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 77.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 89.43 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 39.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 27.89 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 32.69 KB | | [@​sentry/react](https://github.com/sentry/react) | 25.97 KB | | [@​sentry/react](https://github.com/sentry/react) (incl. Tracing) | 38.67 KB | | [@​sentry/vue](https://github.com/sentry/vue) | 27.57 KB | | [@​sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 37.71 KB | | [@​sentry/svelte](https://github.com/sentry/svelte) | 23.45 KB | | CDN Bundle | 24.49 KB | | CDN Bundle (incl. Tracing) | 37.56 KB | | CDN Bundle (incl. Tracing, Replay) | 72.84 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 78.2 KB | | CDN Bundle - uncompressed | 71.93 KB | | CDN Bundle (incl. Tracing) - uncompressed | 111.42 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 225.68 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 238.78 KB | | [@​sentry/nextjs](https://github.com/sentry/nextjs) (client) | 38.92 KB | | [@​sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 36.35 KB | | [@​sentry/node](https://github.com/sentry/node) | 162.82 KB | | [@​sentry/node](https://github.com/sentry/node) - without tracing | 98.95 KB | | [@​sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 126.65 KB | ### [`v8.49.0`](https://github.com/getsentry/sentry-javascript/releases/tag/8.49.0) [Compare Source](getsentry/sentry-javascript@8.48.0...8.49.0) - feat(v8/browser): Flush offline queue on flush and browser online event ([#​14969](getsentry/sentry-javascript#14969)) - feat(v8/react): Add a `handled` prop to ErrorBoundary ([#​14978](getsentry/sentry-javascript#14978)) - fix(profiling/v8): Don't put `require`, `__filename` and `__dirname` on global object ([#​14952](getsentry/sentry-javascript#14952)) - fix(v8/node): Enforce that ContextLines integration does not leave open file handles ([#​14997](getsentry/sentry-javascript#14997)) - fix(v8/replay): Disable mousemove sampling in rrweb for iOS browsers ([#​14944](getsentry/sentry-javascript#14944)) - fix(v8/sveltekit): Ensure source maps deletion is called after source ma… ([#​14963](getsentry/sentry-javascript#14963)) - fix(v8/vue): Re-throw error when no errorHandler exists ([#​14943](getsentry/sentry-javascript#14943)) Work in this release was contributed by [@​HHK1](https://github.com/HHK1) and [@​mstrokin](https://github.com/mstrokin). Thank you for your contribution! #### Bundle size 📦 | Path | Size | | ---------------------------------------------------------------- | ----------------- | | [@​sentry/browser](https://github.com/sentry/browser) | 23.29 KB | | [@​sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 21.96 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 35.85 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 73.19 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 63.58 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 77.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 89.44 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 39.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 27.89 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 32.69 KB | | [@​sentry/react](https://github.com/sentry/react) | 25.97 KB | | [@​sentry/react](https://github.com/sentry/react) (incl. Tracing) | 38.67 KB | | [@​sentry/vue](https://github.com/sentry/vue) | 27.57 KB | | [@​sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 37.71 KB | | [@​sentry/svelte](https://github.com/sentry/svelte) | 23.45 KB | | CDN Bundle | 24.49 KB | | CDN Bundle (incl. Tracing) | 37.56 KB | | CDN Bundle (incl. Tracing, Replay) | 72.84 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 78.2 KB | | CDN Bundle - uncompressed | 71.93 KB | | CDN Bundle (incl. Tracing) - uncompressed | 111.42 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 225.68 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 238.78 KB | | [@​sentry/nextjs](https://github.com/sentry/nextjs) (client) | 38.92 KB | | [@​sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 36.36 KB | | [@​sentry/node](https://github.com/sentry/node) | 162.82 KB | | [@​sentry/node](https://github.com/sentry/node) - without tracing | 98.95 KB | | [@​sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 126.65 KB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca-web/pulls/23 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14942