Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): Add esbuild overrides for vite 6 tests #14815

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore(tests): Add esbuild overrides for vite 6 tests #14815

merged 1 commit into from
Dec 20, 2024

Conversation

chargome
Copy link
Member

Adds an override for esbuild for tests that use vite6.

ref evanw/esbuild#4010

@chargome chargome self-assigned this Dec 20, 2024
@chargome chargome requested a review from mydea December 20, 2024 11:33
Lms24
Lms24 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set a reminder to remove this once the esbuild version is bumped in vite

@chargome chargome merged commit b008139 into develop Dec 20, 2024
129 checks passed
@chargome chargome deleted the cg/add-esbuild-override branch December 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chargome @Lms24