Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Android specifics for ecosystem #2757

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Improve Android specifics for ecosystem #2757

merged 3 commits into from
Jun 1, 2023

Conversation

markushi
Copy link
Member

@markushi markushi commented May 31, 2023 •
edited
Loading

📜 Description

This PR bundles a few Android specific improvements based on some SDK feedback

  • Enable non-transitive R class
  • create empty res/public.xml, automatically marking all resources as private
  • create empty proguard-rules.pro file for sentry-android meta package

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 833a2d1

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 302.90 ms 361.23 ms 58.34 ms
Size 1.72 MiB 2.28 MiB 571.62 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
16cd2b6 243.02 ms 349.69 ms 106.67 ms
46b1782 387.72 ms 458.74 ms 71.02 ms
1707044 338.80 ms 384.79 ms 46.00 ms

App size

Revision Plain With Sentry Diff
16cd2b6 1.72 MiB 2.28 MiB 570.95 KiB
46b1782 1.72 MiB 2.28 MiB 570.44 KiB
1707044 1.72 MiB 2.28 MiB 570.44 KiB

Previous results on branch: feat/sdk-ecosystem-improvements

Startup times

Revision Plain With Sentry Diff
895c3db 300.47 ms 351.37 ms 50.90 ms

App size

Revision Plain With Sentry Diff
895c3db 1.72 MiB 2.28 MiB 571.62 KiB

@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (84b2bbd) 81.09% compared to head (e25b750) 81.09%.

❗ Current head e25b750 differs from pull request most recent head 833a2d1. Consider uploading reports for the commit 833a2d1 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #2757   +/-   ##
=========================================
  Coverage     81.09%   81.09%           
  Complexity     4470     4470           
=========================================
  Files           347      347           
  Lines         16475    16475           
  Branches       2232     2232           
=========================================
  Hits          13361    13361           
  Misses         2181     2181           
  Partials        933      933

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano
Copy link
Member

docs say that you should add an empty <public /> tag in the resource tag in public.xml

romtsn
romtsn approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create empty res/public.xml, automatically marking all resources as private

that is neat, I didn't know that 👍 looks good

@markushi markushi merged commit 8965f9d into main Jun 1, 2023
@markushi markushi deleted the feat/sdk-ecosystem-improvements branch June 1, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markushi @stefanosiano @romtsn