Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Native SDK to v0.6.0 #2545

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Bumps sentry-android-ndk/sentry-native from 0.5.4 to 0.6.0.

Auto-generated by a dependency updater.

Changelog

0.6.0

Breaking changes:

  • When built as a shared library for Android or Linux, the Native SDK limits the export of symbols to the sentry_-prefix. The option SENTRY_EXPORT_SYMBOLS is no longer available and the linker settings are constrained to the Native SDK and no longer PUBLIC to parent projects. (#363)

Features:

  • A session may be ended with a different status code. (#801)

Fixes:

Internal:

Thank you:

Features, fixes and improvements in this release have been contributed by:

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 15, 2023
@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.6.0 branch from cf90d86 to 5159113 Compare February 15, 2023 03:07
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 15, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 292.70 ms 355.89 ms 63.19 ms
Size 1.73 MiB 2.26 MiB 548.01 KiB

Previous results on branch: deps/sentry-android-ndk/sentry-native/0.6.0

Startup times

Revision Plain With Sentry Diff
9cb6164 336.19 ms 380.69 ms 44.50 ms
63abe5c 302.70 ms 335.78 ms 33.08 ms
e6bcc2a 400.10 ms 486.98 ms 86.88 ms
aff2315 312.89 ms 361.81 ms 48.91 ms
08cfb10 301.06 ms 360.40 ms 59.34 ms
8113ac9 289.29 ms 334.48 ms 45.19 ms
cad8877 289.11 ms 347.87 ms 58.77 ms
1daec91 326.28 ms 369.28 ms 43.01 ms
e327132 360.28 ms 408.65 ms 48.37 ms
c093f2b 352.36 ms 393.27 ms 40.90 ms

App size

Revision Plain With Sentry Diff
9cb6164 1.73 MiB 2.26 MiB 548.16 KiB
63abe5c 1.73 MiB 2.26 MiB 548.39 KiB
e6bcc2a 1.73 MiB 2.26 MiB 545.67 KiB
aff2315 1.73 MiB 2.26 MiB 548.61 KiB
08cfb10 1.73 MiB 2.26 MiB 548.61 KiB
8113ac9 1.73 MiB 2.26 MiB 548.61 KiB
cad8877 1.73 MiB 2.26 MiB 548.39 KiB
1daec91 1.73 MiB 2.26 MiB 548.01 KiB
e327132 1.73 MiB 2.26 MiB 548.15 KiB
c093f2b 1.73 MiB 2.26 MiB 548.50 KiB

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (910071f) 81.31% compared to head (226205a) 81.31%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2545   +/-   ##
=========================================
  Coverage     81.31%   81.31%           
  Complexity     4187     4187           
=========================================
  Files           336      336           
  Lines         15486    15486           
  Branches       2021     2021           
=========================================
  Hits          12592    12592           
  Misses         2101     2101           
  Partials        793      793           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn
Copy link
Member

romtsn commented Feb 15, 2023

@markushi I believe there's no action required for us here, right? so we can just go ahead and merge it?

@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.6.0 branch 2 times, most recently from 272e0c2 to 43f95e7 Compare February 15, 2023 13:00
@markushi
Copy link
Member

It's a breaking change in regards to runtime behavior on the sentry-native side, as less symbols are exported now. But as those extra symbols should have never been exposed I'm wondering if we can go ahead and merge this without a major bump.

@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.6.0 branch 10 times, most recently from 3780748 to 8bcf34a Compare February 22, 2023 12:08
@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.6.0 branch 7 times, most recently from 512dbaa to 8f2d0bc Compare March 2, 2023 13:04
@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.6.0 branch 7 times, most recently from 1101159 to 455d7af Compare March 10, 2023 16:13
@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.6.0 branch 8 times, most recently from 8ef8aff to 452a244 Compare March 15, 2023 12:24
@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.6.0 branch 2 times, most recently from 01c2517 to 974d7b0 Compare March 16, 2023 09:40
@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.6.0 branch from 974d7b0 to 226205a Compare March 16, 2023 10:40
@markushi markushi merged commit d0c4495 into main Mar 17, 2023
@markushi markushi deleted the deps/sentry-android-ndk/sentry-native/0.6.0 branch March 17, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants