Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Target Platform Version in mobile TFM monkiers #3798

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell requested a review from vaind November 27, 2024 08:35
Directory.Build.props Outdated Show resolved Hide resolved
@jamescrosswell jamescrosswell marked this pull request as ready for review November 27, 2024 09:07
@jamescrosswell jamescrosswell requested a review from vaind November 27, 2024 09:08
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite a few places to control/update
but easy enough if it's all the same version, just find and replace

@@ -39,7 +39,7 @@ jobs:
with:
name: device-test-android
if-no-files-found: error
path: test/Sentry.Maui.Device.TestApp/bin/Release/net8.0-android/android-x64/io.sentry.dotnet.maui.device.testapp-Signed.apk
path: test/Sentry.Maui.Device.TestApp/bin/Release/net8.0-android34.0/android-x64/io.sentry.dotnet.maui.device.testapp-Signed.apk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use -o when building to set the path, you can have a directory that's not going to change and avoid having to keep up with tfm changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good idea... next time we touch this we can do that instead.

@bruno-garcia bruno-garcia merged commit 9bea4f5 into main Nov 27, 2024
21 checks passed
@bruno-garcia bruno-garcia deleted the pin-target-platform-version branch November 27, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin older iOS versions when building Sentry.Maui
3 participants