Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added properties to CheckIns #3320

Merged
merged 17 commits into from
Apr 29, 2024
Merged

feat: Added properties to CheckIns #3320

merged 17 commits into from
Apr 29, 2024

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Apr 22, 2024 •
edited
Loading

Fixes #3259

Based on our dev docs check-ins now have

- CheckIn ID
- Monitor Slug
- Status
- Duration
- Release
- Environment
- Contexts -> trace -> trace ID

Release and Environment are getting applied by the Enricher.
Duration is an optional parameter and currently gets set by the Hangfire Integration when a task is finished.
The Trace ID gets taken from the scope. Either from the propagation context or, if present, from the current span.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5de8e9a

@bitsandfoxes bitsandfoxes marked this pull request as ready for review April 25, 2024 11:54
jamescrosswell
jamescrosswell approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... suggested a couple of cosmetic changes.

@bitsandfoxes @jamescrosswell
Apply suggestions from code review
5de8e9a 
Review feeback

Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
@bitsandfoxes bitsandfoxes merged commit 5bcb9ca into main Apr 29, 2024
20 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/crons-1 branch April 29, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescrosswell jamescrosswell jamescrosswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CaptureCheckIn always report production environment, even if SDK environment differs
2 participants
@bitsandfoxes @jamescrosswell