Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Functions (Isolated Worker/Out-of-Process) support #2346

Merged
merged 37 commits into from
May 18, 2023
Merged

Azure Functions (Isolated Worker/Out-of-Process) support #2346

merged 37 commits into from
May 18, 2023

Conversation

SeanFeldman
Copy link
Contributor

@SeanFeldman SeanFeldman commented Apr 29, 2023 •
edited
Loading

Adds support for Azure Functions (Isolated Worker/Out-of-Process SDK)

Closes #373

@SeanFeldman
Copy link
Contributor Author

SeanFeldman commented May 1, 2023 •
edited
Loading

Looking at the supported .NET versions, .NET 5 and .NET Standard 2.0 are supported by Microsoft.Azure.Functions.Worke. Should the Sentry package support net5.0 and netstandard2.0 instead of the current net6.0, @mattjohnsonpint?

Discussed. Outcome:

  • Source project to target net6.0 and netstandard2.0
  • Test project to target net6.0, net7.0, and net48

@SeanFeldman
Copy link
Contributor Author

@mattjohnsonpint, keeping it as a draft, but you can start tearing this apart 🙂

@SeanFeldman

This comment was marked as outdated.

Sign in to view
@SeanFeldman SeanFeldman force-pushed the 373-azure-functions branch 2 times, most recently from 5a8094b to f788fcd Compare May 10, 2023 04:21
SeanFeldman
SeanFeldman commented May 10, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -10,6 +10,7 @@
- Build .NET Standard 2.1 for Unity ([#2328](https://github.com/getsentry/sentry-dotnet/pull/2328))
- Add `RemoveExceptionFilter`, `RemoveEventProcessor` and `RemoveTransactionProcessor` extension methods on `SentryOptions` ([#2331](https://github.com/getsentry/sentry-dotnet/pull/2331))
- Include Dynamic Sampling Context with error events, when there's a transaction ([#2332](https://github.com/getsentry/sentry-dotnet/pull/2332))
- Azure Functions (Isolated Worker/Out-of-Process) support ([#2346](https://github.com/getsentry/sentry-dotnet/pull/2346))

This comment was marked as outdated.

Sign in to view

@SeanFeldman SeanFeldman marked this pull request as ready for review May 10, 2023 04:32
@SeanFeldman SeanFeldman requested a review from bitsandfoxes as a code owner May 10, 2023 04:32
@mattjohnsonpint
Copy link
Contributor

Add API approval tests please.

SeanFeldman and others added 14 commits May 12, 2023 02:28
@SeanFeldman SeanFeldman force-pushed the 373-azure-functions branch from 939e9bc to 74ca2c7 Compare May 12, 2023 08:28
@mattjohnsonpint mattjohnsonpint merged commit 83864a5 into main May 18, 2023
@mattjohnsonpint mattjohnsonpint deleted the 373-azure-functions branch May 18, 2023 02:01
@mattjohnsonpint mattjohnsonpint mentioned this pull request May 19, 2023
Merged
@SeanFeldman SeanFeldman mentioned this pull request May 23, 2023
Merged
3 tasks
@mattjohnsonpint mattjohnsonpint mentioned this pull request Jun 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved integration for Azure Functions
2 participants
@SeanFeldman @mattjohnsonpint