Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow tests and race condition #1784

Merged
merged 16 commits into from
Jul 21, 2022
Merged

Fix slow tests and race condition #1784

merged 16 commits into from
Jul 21, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Jul 16, 2022 •
edited
Loading

This should speed up several of the tests. It also improves some test debug output, and fixes a minor race condition in the caching transport (in the handling of InitCacheFlushTimeout) that was only noticeable when shutting down very close to starting (like we do in tests).

@mattjohnsonpint
Copy link
Contributor Author

Looks like a have a little more to do for Init_WithCache_BlocksUntilExistingCacheIsFlushed. Leaving as a draft for now.

@mattjohnsonpint mattjohnsonpint changed the title Fix slow tests Fix slow tests and race condition Jul 20, 2022
@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review July 20, 2022 22:45
@mattjohnsonpint
Copy link
Contributor Author

Skipping Init_WithCache_BlocksUntilExistingCacheIsFlushed in CI. It works fine locally.

@SimonCropp SimonCropp merged commit 997e54a into main Jul 21, 2022
@SimonCropp SimonCropp deleted the fix-slow-tests branch July 21, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonCropp SimonCropp SimonCropp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjohnsonpint @SimonCropp