Set Java/Android SDK options #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
reviewed
Jun 7, 2022
This reverts commit 28b3e43.
|
I had to revert the last commit. I was attempting to map Java enums to C# enums using the recommended approach documented here. The library compiled fine, but generated the wrong method signature in the Android Callable Wrapper, so failed when building one of the sample apps. I hunted for a workaround but found none. I need to raise this as an upstream issue to Microsoft, but in the meantime we can just keep things as they were. |
|
FYI - the enum issue is reported here: dotnet/java-interop#991 |
SimonCropp
reviewed
Jun 9, 2022
SimonCropp
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets most of the Java/Android SDK options when using the
net6.0-androidtarget from the .NET SDK.SentryOptionsandSentryAndroidOptionsare not available on ours at all, so I have exposed them onSentryOptions.Androidand mirrored the defaults.This is also relevant for MAUI.
Note, #1692 and #1693 need to be in place before this works.
Also, we currently have no way to write unit tests for this code, but it's all been run manually several times on my box.