Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore vs code #1534

Merged
merged 1 commit into from
Mar 22, 2022
Merged

ignore vs code #1534

merged 1 commit into from
Mar 22, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Mar 17, 2022

#skip-changelog

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #1534 (a978cc7) into main (b26a2fb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
- Coverage   84.43%   84.42%   -0.02%     
==========================================
  Files         219      219              
  Lines        7388     7388              
  Branches     1416     1416              
==========================================
- Hits         6238     6237       -1     
  Misses        722      722              
- Partials      428      429       +1     
Impacted Files Coverage Δ
src/Sentry/Exceptions/SentryStackFrame.cs 76.92% <0.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26a2fb...a978cc7. Read the comment docs.

@mattjohnsonpint
Copy link
Contributor

There is some value in sharing VS Code settings, though not everyone uses the same settings. I could go either way with this. @bruno-garcia?

@SimonCropp
Copy link
Contributor Author

SimonCropp commented Mar 18, 2022

@mattjohnsonpint agreed. but in my experience it is not possible to distinguish between what is shared and what is custom. so to have any shared settings u need to give up any personal customisation

@mattjohnsonpint mattjohnsonpint merged commit 0f43bdb into main Mar 22, 2022
@mattjohnsonpint mattjohnsonpint deleted the ignore-vs-code branch March 22, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants