Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sql listener integration testing #1456

Merged
merged 82 commits into from
Mar 2, 2022
Merged

Sql listener integration testing #1456

merged 82 commits into from
Mar 2, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Feb 3, 2022 •
edited
Loading

#skip-changelog

@SimonCropp SimonCropp marked this pull request as draft February 3, 2022 01:56
@SimonCropp SimonCropp marked this pull request as ready for review March 1, 2022 21:25
bruno-garcia
bruno-garcia approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

test/Sentry.DiagnosticSource.IntegrationTests/Sentry.DiagnosticSource.IntegrationTests.csproj Outdated Show resolved Hide resolved
test/Sentry.DiagnosticSource.IntegrationTests/SentryDiagnosticSubscriberTests.cs Outdated Show resolved Hide resolved
@SimonCropp @bruno-garcia
Update test/Sentry.DiagnosticSource.IntegrationTests/SentryDiagnostic…
6991627 
…SubscriberTests.cs

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
lucas-zimerman
lucas-zimerman approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than
#1456 (review)
and
#1456 (comment)
lgtm

@SimonCropp SimonCropp merged commit 301a24e into main Mar 2, 2022
@SimonCropp SimonCropp deleted the sqlListenerStuff branch March 2, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonCropp @codecov-commenter @bruno-garcia @lucas-zimerman @getsentry-bot