fix: Keep events in case of nonserializable context #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
requested review from
bruno-garcia and
lucas-zimerman
as code owners
bruno-garcia
force-pushed
the
fix/keep-events
branch
from
deafcbd to
87ab80d
Compare
bruno-garcia
approved these changes
Dec 18, 2021
|
Turns out what exception is thrown changed from netcore 2.1 and other targets. |
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
- Coverage 83.01% 82.72% -0.29%
==========================================
Files 217 217
Lines 7295 7306 +11
Branches 1411 1415 +4
==========================================
- Hits 6056 6044 -12
- Misses 804 831 +27
+ Partials 435 431 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.