-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device and gpu protocols updated; public IJsonSerializable #1063
Device and gpu protocols updated; public IJsonSerializable #1063
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
+ Coverage 79.52% 81.22% +1.70%
==========================================
Files 194 194
Lines 6349 6451 +102
Branches 1530 1564 +34
==========================================
+ Hits 5049 5240 +191
+ Misses 868 758 -110
- Partials 432 453 +21
Continue to review full report at Codecov.
|
…ntry-dotnet into feature/protocols-updated
Added the tests. Please, review @Tyrrrz @bruno-garcia as I'd like to start the integration on Unity side for these protocols. Also, why danger fails again? |
Please consider adding a changelog entry for the next release. Instructions and example for changelog Example: |
Perhaps using const names for the field names, for example:
|
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
I was relying on the current style. I haven't seen such usage from within the project, so used directly. |
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Related to getsentry/sentry-unity#49, check latest comment (which starts with 'Proposed changes').
I made
IJsonSerializable
public, because we'll have a new context on Unity side. Although, I'm not sure aboutsummary
description.I also plan to update the docs, but after this part will be merged.
I plan to update the tests too. Still WIP.