ci: Fix TestFlight upload for previews #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App Store connect requires a period-separated list of at most three non-negative integers for the version. Therefore the version bump script must not add the suffixes of preview releases. This is fixed now.
added 2 commits
March 3, 2021 09:47
…y/sentry-cocoa into ci/fix-app-store-connect-upload
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
==========================================
+ Coverage 94.73% 94.76% +0.02%
==========================================
Files 78 78
Lines 3589 3589
==========================================
+ Hits 3400 3401 +1
+ Misses 189 188 -1
Continue to review full report at Codecov.
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
App Store connect requires a period-separated list of at most three non-negative integers
for the version. Therefore we remove now the preview version suffixes with Fastlane before
uploading.
💡 Motivation and Context
The upload of iOS-Swift to TestFlight failed.
💚 How did you test it?
With CI.
📝 Checklist
🔮 Next steps