impr: Slightly speed up serializing scope #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a double checked lock for getting the span when building the trace context.
philipphofmann
requested review from
brustolin,
armcknight and
philprime
as code owners
brustolin
approved these changes
Dec 23, 2024
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e579af | 1239.40 ms | 1257.29 ms | 17.89 ms |
| 7bbb7c3 | 1232.40 ms | 1249.78 ms | 17.38 ms |
| 49819af | 1263.92 ms | 1275.66 ms | 11.74 ms |
| 0a12181 | 1231.37 ms | 1248.13 ms | 16.75 ms |
| 3cba0e8 | 1243.04 ms | 1257.46 ms | 14.42 ms |
| 187edbf | 1224.29 ms | 1239.69 ms | 15.40 ms |
| 5ab598f | 1213.90 ms | 1240.45 ms | 26.55 ms |
| c2dd146 | 1233.69 ms | 1246.37 ms | 12.67 ms |
| f4a6925 | 1228.73 ms | 1252.18 ms | 23.45 ms |
| 216bdf9 | 1202.57 ms | 1215.45 ms | 12.88 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e579af | 21.58 KiB | 656.60 KiB | 635.02 KiB |
| 7bbb7c3 | 21.58 KiB | 418.78 KiB | 397.20 KiB |
| 49819af | 20.76 KiB | 427.31 KiB | 406.55 KiB |
| 0a12181 | 21.58 KiB | 419.20 KiB | 397.61 KiB |
| 3cba0e8 | 22.84 KiB | 403.19 KiB | 380.34 KiB |
| 187edbf | 21.58 KiB | 729.90 KiB | 708.32 KiB |
| 5ab598f | 22.84 KiB | 403.17 KiB | 380.33 KiB |
| c2dd146 | 21.58 KiB | 713.91 KiB | 692.33 KiB |
| f4a6925 | 21.58 KiB | 706.46 KiB | 684.88 KiB |
| 216bdf9 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4661 +/- ##
=============================================
- Coverage 90.668% 90.633% -0.036%
=============================================
Files 621 621
Lines 71159 71155 -4
Branches 25954 25336 -618
=============================================
- Hits 64519 64490 -29
- Misses 6543 6572 +29
+ Partials 97 93 -4
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use a double checked lock for getting the span when building the trace context.
💡 Motivation and Context
@armcknight found this.
💚 How did you test it?
Unit tests still green.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps