ref: Add comment why no lock required in scope #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a short comment to explain why we don't need to call synchronize spanLock when building the trace context in SentryScope.applyToEvent.
philipphofmann
requested review from
brustolin,
armcknight and
philprime
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4648 +/- ##
=============================================
- Coverage 90.626% 90.617% -0.010%
=============================================
Files 620 620
Lines 71075 71066 -9
Branches 25898 25868 -30
=============================================
- Hits 64413 64398 -15
- Misses 6565 6570 +5
- Partials 97 98 +1
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cd72e5c | 1238.96 ms | 1256.84 ms | 17.88 ms |
| 9d61bea | 1243.88 ms | 1254.36 ms | 10.48 ms |
| 2af280d | 1246.22 ms | 1253.10 ms | 6.88 ms |
| b6ba04e | 1230.48 ms | 1253.20 ms | 22.72 ms |
| ddc9b9a | 1201.71 ms | 1226.70 ms | 24.99 ms |
| 6e1452d | 1241.69 ms | 1253.47 ms | 11.78 ms |
| cd76c54 | 1223.41 ms | 1249.65 ms | 26.24 ms |
| aa45f36 | 1217.59 ms | 1236.86 ms | 19.27 ms |
| a34f08c | 1234.08 ms | 1246.40 ms | 12.31 ms |
| e5dcbd5 | 1223.47 ms | 1243.90 ms | 20.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cd72e5c | 22.85 KiB | 414.74 KiB | 391.89 KiB |
| 9d61bea | 20.76 KiB | 436.29 KiB | 415.53 KiB |
| 2af280d | 20.76 KiB | 435.22 KiB | 414.46 KiB |
| b6ba04e | 20.76 KiB | 414.44 KiB | 393.68 KiB |
| ddc9b9a | 20.76 KiB | 420.40 KiB | 399.65 KiB |
| 6e1452d | 21.58 KiB | 419.68 KiB | 398.10 KiB |
| cd76c54 | 21.58 KiB | 675.85 KiB | 654.27 KiB |
| aa45f36 | 21.58 KiB | 616.73 KiB | 595.15 KiB |
| a34f08c | 22.30 KiB | 730.30 KiB | 708.00 KiB |
| e5dcbd5 | 22.85 KiB | 414.09 KiB | 391.24 KiB |
brustolin
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a short comment to explain why we don't need to call synchronize spanLock when building the trace context in SentryScope.applyToEvent.
#skip-changelog